Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin hipscat version #435

Closed
wants to merge 2 commits into from
Closed

pin hipscat version #435

wants to merge 2 commits into from

Conversation

wilsonbb
Copy link
Collaborator

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

  • I have added a function that requires a sync_tables command, and have added the neccesary sync_tables call

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

github-actions bot commented Apr 26, 2024

Before [6c8f1b4] After [af7f49e] Ratio Benchmark (Parameter)
35.2±1ms 38.0±1ms 1.08 benchmarks.time_batch
35.4±0.6ms 37.3±0.3ms 1.06 benchmarks.time_prune_sync_workflow

Click here to view all benchmarks.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.65%. Comparing base (6c8f1b4) to head (f5cec1f).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #435       +/-   ##
===========================================
- Coverage   95.82%   71.65%   -24.17%     
===========================================
  Files          25       25               
  Lines        1771     1771               
===========================================
- Hits         1697     1269      -428     
- Misses         74      502      +428     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wilsonbb
Copy link
Collaborator Author

wilsonbb commented May 3, 2024

Closing debugging PR

@wilsonbb wilsonbb closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant